-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External raw records #292
Merged
Merged
External raw records #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7182529346
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the raw_records (DAQReader) plugin to allow for creating raw_records_ext, a new type of data that is intended to be used for measuring signals out of the TPC. For example, we can use it as a "software external trigger": measure some signals with an external TPC and select on events that come in coincidence with some peak in the external PMT.
For this reason, we want to have a complete separate chain of raw_records-peaks that follow a separate processing wrt the TPC PMTs. This is implemented in a very similar way as the neutron and muon veto detectors are treated in XENONnT.
We define the PMT channels in the context channel map:
'top' and 'bottom' are required, while 'external' defaults to (-1,-1).
We now have:
These copies of the original plugins do all similar things but just with raw_records coming from external channels (in this case channel 5). Some fine tuning might be needed on the specific requirements for the processing of these peaks. The processing of normal records and peaks should be unchanged.
NOTE: it is important to preserve always the same lineage_hash for raw_records. This is possible by having the raw_records as the last type produced in the DAQReader plugin, because the lineage comes from the last plugin.
Here an example notebook used to test this new framework, assuming that channel 4 would be an external PMT.
new_raw_records.pdf